feat(sdk-coin-osmo): allow amount in execute contract transaction #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkjnr
force-pushed
the
fix-contract-amount
branch
from
61e8a93
to
13ff2d7
Compare
dpkjnr
force-pushed
the
fix-contract-amount
branch
from
9aa3b48
to
44be383
Compare
| @@ -224,13 +224,14 @@ export class CosmosTransaction extends BaseTransaction { | |||
| case TransactionType.ContractCall: | |||
| explanationResult.type = TransactionType.ContractCall; | |||
| message = json.sendMessages[0].value as ExecuteContractMessage; | |||
| outputAmount = message.funds?.[0]?.amount ?? '0'; | |||
There was a problem hiding this comment.
what changed suddenly and could you add some description as well ? ticket doesn't indicate why this was needed
There was a problem hiding this comment.
Changes LGTM. But yes +1 on the above comment.
DinshawKothari
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-23